Skip to content

Revert "Fix EADDRINUSE errors in distributed tests with port manager and retry logic" #21341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "Fix EADDRINUSE errors in distributed tests with port manager and retry logic" #21341

wants to merge 1 commit into from
+7 −1,208

Conversation

@bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Nov 6, 2025 •
edited
Loading

What does this PR do?
Reverts #21309

Preparation for: #21335

This revert removes the port management logic and switches to a simpler approach for addressing port-related issues, as this is specific to standalone test environments.
The initial step for this change has been introduced in Lightning-AI/utilities — reference: Lightning-AI/utilities#447

cc: @deependujha

📚 Documentation preview 📚: https://pytorch-lightning--21341.org.readthedocs.build/en/21341/

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Nov 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025 •
edited
Loading

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success ✅

These checks are required after the changes to src/lightning/fabric/plugins/environments/lightning.py, src/lightning/fabric/utilities/port_manager.py, tests/tests_pytorch/conftest.py.

🟢 pytorch_lightning: lit GPU
Check ID Status
pytorch.yml / Lit Job (nvidia/cuda:12.1.1-devel-ubuntu22.04, pytorch, 3.10) success ✅
pytorch.yml / Lit Job (lightning, 3.12) success ✅
pytorch.yml / Lit Job (pytorch, 3.12) success ✅

These checks are required after the changes to tests/tests_pytorch/conftest.py, src/lightning/fabric/plugins/environments/lightning.py, src/lightning/fabric/utilities/port_manager.py.

🟢 Benchmarks
Check ID Status
benchmark.yml / Lit Job (fabric) success ✅
benchmark.yml / Lit Job (pytorch) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/environments/lightning.py, src/lightning/fabric/utilities/port_manager.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success ✅
docs-make (fabric, html) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/environments/lightning.py, src/lightning/fabric/utilities/port_manager.py.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu-guardian success ✅

These checks are required after the changes to src/lightning/fabric/plugins/environments/lightning.py, src/lightning/fabric/utilities/port_manager.py, tests/tests_fabric/conftest.py, tests/tests_fabric/plugins/environments/test_lightning.py, tests/tests_fabric/utilities/test_port_manager.py.

🔴 lightning_fabric: lit GPU
Check ID Status
fabric.yml / Lit Job (nvidia/cuda:12.1.1-devel-ubuntu22.04, fabric, 3.10) success ✅
fabric.yml / Lit Job (fabric, 3.12) failure ❌
fabric.yml / Lit Job (lightning, 3.12) success ✅

These checks are required after the changes to src/lightning/fabric/plugins/environments/lightning.py, src/lightning/fabric/utilities/port_manager.py, tests/tests_fabric/conftest.py, tests/tests_fabric/plugins/environments/test_lightning.py, tests/tests_fabric/utilities/test_port_manager.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/lightning/fabric/plugins/environments/lightning.py, src/lightning/fabric/utilities/port_manager.py.

🟢 install
Check ID Status
install-pkg-guardian success ✅

These checks are required after the changes to src/lightning/fabric/plugins/environments/lightning.py, src/lightning/fabric/utilities/port_manager.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 70 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov
Copy link

codecov bot commented Nov 6, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (19912d0) to head (4efe570).
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #21341   +/-   ##
=======================================
- Coverage      87%      87%   -0%     
=======================================
  Files         270      269    -1     
  Lines       23799    23705   -94     
=======================================
- Hits        20629    20535   -94     
  Misses       3170     3170

@deependujha
Copy link
Collaborator

deependujha commented Nov 6, 2025

Rather than a separate PR, I believe, we should merge the two PRs.

@deependujha
Copy link
Collaborator

deependujha commented Nov 6, 2025

pr merged in #21335. closing this.

@deependujha deependujha closed this Nov 6, 2025
@deependujha deependujha deleted the revert-21309-fix/port-manager-eaddrinuse branch November 6, 2025 05:33
@deependujha deependujha mentioned this pull request Nov 6, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees

No one assigned

Labels

fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bhimrazy @deependujha